-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support #45
base: feature
Are you sure you want to change the base?
RTL Support #45
Conversation
1d8e74e
to
26a5f00
Compare
f2a2973
to
5e51c59
Compare
a13233a
to
dba4f49
Compare
d8c611d
to
4ebdc2b
Compare
b54f508
to
a455e07
Compare
914ad0e
to
0e44a34
Compare
@@ -96,6 +96,11 @@ int SmallestPowerOf2(int x) { | |||
return x; | |||
} | |||
|
|||
bool IsCharRTL(wxChar c) { | |||
// only hebrew for now | |||
return (((wxChar)0x5d0) <= c) && (c <= ((wxChar)0x5ea)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested, but this should be better and support all the RTL character.
return (((wxChar)0x5d0) <= c) && (c <= ((wxChar)0x5ea)); | |
bool IsCharRTL(wxChar character) { | |
hb_unicode_funcs_t* unicode_funcs = hb_unicode_funcs_get_default(); | |
hb_script_t script = hb_unicode_script(unicode_funcs, character); | |
return hb_script_get_horizontal_direction(script) == HB_DIRECTION_RTL; | |
} |
I would like to insert this feature, @arch1t3cht are you okay with this, or you want me to find a better solution to handle RTL? I now have time and want to invest for a good solution. |
No description provided.